-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add find_duplicate_points
Internal API
#815
Add find_duplicate_points
Internal API
#815
Conversation
combine_duplicate_points
Internal APIcombine_duplicate_points
Internal API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My only concern is with the naming.
|
||
/** | ||
* @internal | ||
* @brief For each multipoint, computes duplicate points and stores as stencil. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "stores as stencil"? Do you mean an array of flags indicating which points are duplicates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc updated as a result of addressing: #815 (comment)
|
||
template <typename VecIterator> | ||
template <typename IndexType> | ||
CUSPATIAL_HOST_DEVICE auto multipoint_ref<VecIterator>::operator[](IndexType i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking about host / device here. Is this really intended to work on the host? What if it is called from host when the iterator points to device memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can work on host, if all vectors are host vectors. Although I don't really see a use case at the moment. Up till now I mostly rely on developer's prudence to not access device memory from host.
cpp/include/cuspatial/experimental/detail/combine/combine_points.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/detail/find/find_duplicate_points.cuh
Outdated
Show resolved
Hide resolved
combine_duplicate_points
Internal APIfind_duplicate_points
Internal API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving CMake changes
@gpucibot merge |
Description
This PR adds
combine_duplicate_points
API. Given a multipoints range, this API sets a stencil range for each of the duplicate points in the multipoint range.closes #814
A second introduction in this PR is
make_multipoint_array
, a test utility to create an owning object with pure initializer_list syntax for convenience construction. Example usage:Checklist