Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit configuration and CI #799

Merged
merged 6 commits into from
Nov 16, 2022
Merged

Update pre-commit configuration and CI #799

merged 6 commits into from
Nov 16, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 15, 2022

Description

This PR updates the pre-commit configuration and uses pre-commit for all CI style checks. This aligns the configuration closer to that of cudf, but does not add all of the hooks from cudf's list to keep this PR limited in scope.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested review from a team as code owners November 15, 2022 03:45
@bdice bdice requested a review from cwharris November 15, 2022 03:45
@github-actions github-actions bot added gpuCI Related to Continuous Integration / Automation Java Python Related to Python code labels Nov 15, 2022
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 15, 2022
@jarmak-nv jarmak-nv removed the Java label Nov 15, 2022
@bdice bdice self-assigned this Nov 15, 2022
@harrism
Copy link
Member

harrism commented Nov 16, 2022

Thanks for this @bdice !

@harrism harrism added the Java Related to Java code label Nov 16, 2022
@bdice
Copy link
Contributor Author

bdice commented Nov 16, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 69cbaa3 into rapidsai:branch-22.12 Nov 16, 2022
@bdice bdice mentioned this pull request Nov 17, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees

@bdice bdice

Labels
gpuCI Related to Continuous Integration / Automation improvement Improvement / enhancement to an existing function Java Related to Java code non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @harrism @ajschmidt8 @jarmak-nv