Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate bounding box code #793

Merged
merged 10 commits into from
Nov 23, 2022

Conversation

harrism
Copy link
Member

@harrism harrism commented Nov 9, 2022

Fixes #746. Replaces the header-only trajectory_bounding_boxes with point_bounding_boxes and reuses it to implement linestring_bounding_boxes and polygon_bounding_boxes.

By providing a single header-only function point_bounding_boxes that forms the implementation of trajectory_bounding_boxes, linestring_bounding_boxes, and polygon_bounding_boxes, this PR also closes closes 567 and closes 568.

It does not, as point_bounding_boxes takes IDs, not polygon and ring offsets as the other APIs do. So we can't quite mark those as fixed.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Nov 9, 2022
@harrism harrism added breaking Breaking change improvement Improvement / enhancement to an existing function labels Nov 9, 2022
@harrism harrism marked this pull request as ready for review November 10, 2022 01:31
@harrism harrism requested review from a team as code owners November 10, 2022 01:31
@harrism harrism requested review from robertmaynard, trxcllnt, cwharris and isVoid and removed request for cwharris November 10, 2022 01:31
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that cpp/tests/CMakeLists.txt needs to be updated since we renamed experimental/trajectory/trajectory_bounding_boxes_test.cu

@harrism
Copy link
Member Author

harrism commented Nov 10, 2022

I believe that cpp/tests/CMakeLists.txt needs to be updated since we renamed experimental/trajectory/trajectory_bounding_boxes_test.cu

You must have missed where I updated it? It's now called POINT_BOUNDING_BOXES_TEST_EXP

Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup!

@harrism harrism self-assigned this Nov 14, 2022
@harrism harrism added c++ and removed libcuspatial Relates to the cuSpatial C++ library labels Nov 14, 2022
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Nov 15, 2022
@harrism harrism removed the c++ label Nov 16, 2022
@trxcllnt
Copy link
Contributor

rerun tests

@harrism
Copy link
Member Author

harrism commented Nov 22, 2022

Ugh, I wish pre-commit would run for github-ui commits.

Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprroving CMake changes

@harrism
Copy link
Member Author

harrism commented Nov 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 367dbf9 into rapidsai:branch-22.12 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA] Consolidate C++ bounding box API functionality
4 participants