-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate bounding box code #793
Consolidate bounding box code #793
Conversation
…radius parameter.
…d test of expansion_radius.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that cpp/tests/CMakeLists.txt
needs to be updated since we renamed experimental/trajectory/trajectory_bounding_boxes_test.cu
You must have missed where I updated it? It's now called POINT_BOUNDING_BOXES_TEST_EXP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good cleanup!
rerun tests |
Ugh, I wish pre-commit would run for github-ui commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aprroving CMake changes
@gpucibot merge |
Fixes #746. Replaces the header-only
trajectory_bounding_boxes
withpoint_bounding_boxes
and reuses it to implementlinestring_bounding_boxes
andpolygon_bounding_boxes
.By providing a single header-only functionpoint_bounding_boxes
that forms the implementation oftrajectory_bounding_boxes
,linestring_bounding_boxes
, andpolygon_bounding_boxes
, this PR also closes closes 567 and closes 568.It does not, as
point_bounding_boxes
takes IDs, not polygon and ring offsets as the other APIs do. So we can't quite mark those as fixed.Checklist