Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conda channel order #787

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Fix conda channel order #787

merged 2 commits into from
Nov 8, 2022

Conversation

harrism
Copy link
Member

@harrism harrism commented Nov 8, 2022

Description

Moves NVIDIA channel last in in the conda dev environment channel list to fix solving when building from source / rapids-compose.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested a review from a team as a code owner November 8, 2022 03:21
@github-actions github-actions bot added the conda Related to conda and conda configuration label Nov 8, 2022
@harrism harrism self-assigned this Nov 8, 2022
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 8, 2022
@harrism harrism changed the title Fix conda channel order. Fix conda channel order Nov 8, 2022
@bdice
Copy link
Contributor

bdice commented Nov 8, 2022

@harrism Please merge this into your PR: harrism#1

I thought there would be additional places to fix, but apparently not. cuSpatial was simple to fix compared to some other repos.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@harrism harrism requested a review from bdice November 8, 2022 05:11
msadang
msadang approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harrism
Copy link
Member Author

harrism commented Nov 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ba94607 into rapidsai:branch-22.12 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@msadang msadang msadang approved these changes

Assignees

@harrism harrism

Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harrism @bdice @msadang