Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorized Load, refactors type_utils.hpp into iterator_factory.cuh #692

Merged
merged 12 commits into from
Sep 29, 2022
Merged

Vectorized Load, refactors type_utils.hpp into iterator_factory.cuh #692

merged 12 commits into from
Sep 29, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Sep 24, 2022 •
edited
Loading

Description

This PR refactors type_utils.hpp into iterator_factory.cuh and introduce utilize sfinae to adapt vectorized load from interleaved coordinate inputs. It also adds documentation to previously missing APIs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Sep 24, 2022
@isVoid isVoid marked this pull request as ready for review September 26, 2022 22:20
@isVoid isVoid requested a review from a team as a code owner September 26, 2022 22:20
@isVoid isVoid added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Sep 26, 2022
@isVoid isVoid changed the title Vectorized Load, Minor refactoring of type_utils.hpp Vectorized Load, refactors type_utils.hpp into iterator_factory.cuh Sep 27, 2022
@isVoid isVoid assigned isVoid and unassigned thomcom and harrism Sep 27, 2022
@isVoid isVoid requested review from thomcom and harrism and removed request for trxcllnt and jrhemstad September 27, 2022 00:27
harrism
harrism requested changes Sep 27, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerned about strict aliasing violation.

cpp/include/cuspatial/experimental/iterator_factory.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/experimental/iterator_factory.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/experimental/iterator_factory.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/experimental/iterator_factory.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/experimental/iterator_factory.cuh Outdated Show resolved Hide resolved
@isVoid isVoid requested a review from harrism September 28, 2022 06:00
@isVoid
Copy link
Contributor Author

isVoid commented Sep 29, 2022

rerun tests

@thomcom
Copy link
Contributor

thomcom commented Sep 29, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6922ef5 into rapidsai:branch-22.10 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team feature request New feature or request libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isVoid @thomcom @harrism