Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build benchmarks in CI #597

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 20, 2022

This PR adds the ability to build benchmarks to build.sh, and passes the necessary option through from the conda build.sh. This change ensures that benchmarks must be able to build against changes in new PRs.

@vyasr vyasr added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 20, 2022
@vyasr vyasr requested a review from a team as a code owner July 20, 2022 01:34
@vyasr vyasr self-assigned this Jul 20, 2022
@github-actions github-actions bot added the conda Related to conda and conda configuration label Jul 20, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Jul 20, 2022

The benchmarks are now built. For instance, the CI log now contains:

[124/130] sccache $BUILD_PREFIX/bin/x86_64-conda-linux-gnu-c++ -DCUDF_VERSION=22.08.00 -DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DJITIFY_USE_CACHE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -I$SRC_DIR/cpp/build/_deps/benchmark-src/src/../include -I$SRC_DIR/cpp/benchmarks -I$SRC_DIR/cpp -I$SRC_DIR/cpp/src -I$PREFIX/include/rapids/libcudacxx -I$PREFIX/include/libcudf/Thrust -I$PREFIX/include/libcudf/Thrust/dependencies -I$SRC_DIR/cpp/include -fvisibility-inlines-hidden -std=c++17 -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/libcuspatial-split- -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -fvisibility-inlines-hidden -std=c++17 -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /opt/conda/envs/rapids/include -isystem /usr/local/cuda/include -O3 -DNDEBUG -fPIE -Wall -Werror -Wno-unknown-pragmas -Wno-error=deprecated-declarations -Wno-deprecated-declarations -pthread -MD -MT benchmarks/CMakeFiles/HAUSDORFF_BENCH.dir/hausdorff_benchmark.cpp.o -MF benchmarks/CMakeFiles/HAUSDORFF_BENCH.dir/hausdorff_benchmark.cpp.o.d -o benchmarks/CMakeFiles/HAUSDORFF_BENCH.dir/hausdorff_benchmark.cpp.o -c $SRC_DIR/cpp/benchmarks/hausdorff_benchmark.cpp

Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @vyasr !

@vyasr
Copy link
Contributor Author

vyasr commented Jul 21, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f7fea6f into rapidsai:branch-22.08 Jul 21, 2022
@vyasr vyasr deleted the build/benchmarks branch July 21, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants