Fix out of bounds access in spline interpolation #544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cubic spline API supports fitting many splines at once. Each spline's coefficients are stored on construction of the
CubicSpline
object, and when users specify a set of points at which to evaluate that spline they can specify which spline to evaluate for each of the input points. When a user does not specify that information, the call operator defaults to assuming that only a single spline exists and interpolates all the data using that spline by setting all input points to use spline 0. Currently, however, the code for creating that default list only makes it as long as the number of knots in the spline instead of making it as long as the set of input points to evaluate the spline at. This leads to out of bounds memory accesses when that curve is fit.