Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang-format to pre-commit hook #505

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Add clang-format to pre-commit hook #505

merged 1 commit into from
Apr 7, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Mar 30, 2022

This PR adds clang format to pre-commit hook.

closes #503

@isVoid isVoid self-assigned this Mar 30, 2022
@isVoid isVoid added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 30, 2022
harrism
harrism approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use pre-commit, but I assume this is the same as other repos, so approving.

@harrism harrism requested a review from vyasr March 31, 2022 05:28
vyasr
vyasr approved these changes Mar 31, 2022
View reviewed changes
.pre-commit-config.yaml Show resolved Hide resolved
@harrism
Copy link
Member

harrism commented Mar 31, 2022

@isVoid this needs to be retargeted to 22.06. do not merge to 22.04.

@isVoid isVoid changed the base branch from branch-22.04 to branch-22.06 March 31, 2022 22:32
@isVoid
Copy link
Contributor Author

isVoid commented Apr 7, 2022

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Apr 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9b7e1d7 into rapidsai:branch-22.06 Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Add Clang-format to Pre-commit Hooks
3 participants
@isVoid @harrism @vyasr