Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore removed --expt-relaxed-constexpr #1502

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Restore removed --expt-relaxed-constexpr #1502

merged 1 commit into from
Dec 18, 2024

Conversation

harrism
Copy link
Member

@harrism harrism commented Dec 17, 2024

Description

Fixes #1501.

Restores removed --expt-relaxed-constexpr for libcuspatial

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested a review from a team as a code owner December 17, 2024 00:05
@harrism harrism requested a review from isVoid December 17, 2024 00:05
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Dec 17, 2024
@harrism harrism requested a review from vyasr December 17, 2024 00:06
@vyasr vyasr mentioned this pull request Dec 18, 2024
Merged
@raydouglass raydouglass merged commit ba4385e into rapidsai:branch-25.02 Dec 18, 2024
41 of 69 checks passed
@harrism harrism mentioned this pull request Dec 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

@vyasr vyasr Awaiting requested review from vyasr

Assignees
No one assigned
Labels
cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]:libcuspatial requires --expt-relaxed-constexpr and fails to build.
3 participants
@harrism @trxcllnt @raydouglass