Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix geopandas upgrades #1404

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Fix geopandas upgrades #1404

merged 7 commits into from
Jul 10, 2024

Conversation

quasiben
Copy link
Member

@quasiben quasiben commented Jul 9, 2024

Exploring notebook fixes with geopandas 1.0.1

@quasiben quasiben requested a review from a team as a code owner July 9, 2024 01:38
@quasiben quasiben requested review from thomcom and harrism July 9, 2024 01:38
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the Python Related to Python code label Jul 9, 2024
@isVoid isVoid added bug Something isn't working non-breaking Non-breaking change labels Jul 9, 2024
isVoid
isVoid approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebooks are working for me locally. IMO we shouldn't overwork this. geodatasets is a nice improvement to how we can get open source map data, but it's out of scope to introduce them to cuspatial in this PR.

docs/source/user_guide/cuspatial_api_examples.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/cuspatial_api_examples.ipynb Outdated Show resolved Hide resolved
@isVoid isVoid mentioned this pull request Jul 9, 2024
Closed
@isVoid isVoid linked an issue Jul 9, 2024 that may be closed by this pull request
[DOC]: Remove deprecated geopandas.dataset usage in cuspatial_api_examples.ipynb #1403
Closed
@github-actions github-actions bot removed the Python Related to Python code label Jul 9, 2024
@jameslamb jameslamb mentioned this pull request Jul 9, 2024
Merged
@quasiben quasiben changed the title [WIP] Fix geopandas upgrades [Fix geopandas upgrades Jul 9, 2024
@quasiben quasiben changed the title [Fix geopandas upgrades Fix geopandas upgrades Jul 9, 2024
@quasiben
Copy link
Member Author

quasiben commented Jul 9, 2024

Thanks for the fixes @isVoid . Is this ready to be merged in now ?

@isVoid
Copy link
Contributor

isVoid commented Jul 10, 2024

Thanks for the fixes @isVoid . Is this ready to be merged in now ?

Yes I believe it is.

@isVoid
Copy link
Contributor

isVoid commented Jul 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit c8616c1 into rapidsai:branch-24.08 Jul 10, 2024
69 checks passed
@jameslamb jameslamb mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@thomcom thomcom Awaiting requested review from thomcom thomcom was automatically assigned from rapidsai/cuspatial-python-codeowners

@harrism harrism Awaiting requested review from harrism harrism was automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC]: Remove deprecated geopandas.dataset usage in cuspatial_api_examples.ipynb
2 participants
@quasiben @isVoid