Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write PROJ build dir export rules #1347

Merged
merged 1 commit into from
Feb 27, 2024
Merged

write PROJ build dir export rules #1347

merged 1 commit into from
Feb 27, 2024

Conversation

trxcllnt
Copy link
Contributor

PROJ doesn't generate export rules in its build dir, so the pip package doesn't find it when using cuPROJ from its build dir.

This PR ensures that configuring the pip package to use cuPROJ from its build dir also uses PROJ from the _deps/proj-build dir.

@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 25, 2024
@trxcllnt trxcllnt requested a review from a team as a code owner February 25, 2024 23:26
@trxcllnt trxcllnt requested a review from vyasr February 25, 2024 23:26
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Feb 25, 2024
@trxcllnt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9268b36 into rapidsai:branch-24.04 Feb 27, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trxcllnt @robertmaynard @vyasr