Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve zipcode counting notebook by adding GPU backed WKT parser #1130

Merged
merged 2 commits into from
May 15, 2023
Merged

Improve zipcode counting notebook by adding GPU backed WKT parser #1130

merged 2 commits into from
May 15, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented May 9, 2023

Description

This PR improves the zipcode counting notebook by utilizing cudf string and list column methods to parse WKT as geometry column. This achieves 40X speed up comparing to parsing on host.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the Python Related to Python code label May 9, 2023
@isVoid isVoid added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 9, 2023
@isVoid isVoid self-assigned this May 9, 2023
@isVoid isVoid requested review from harrism and thomcom May 10, 2023 00:57
harrism
harrism approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speedup is awesome. Suggesting one bit of explanation.

notebooks/ZipCodes_Stops_PiP_cuSpatial.ipynb Show resolved Hide resolved
@harrism harrism requested a review from jarmak-nv May 11, 2023 00:58
jarmak-nv
jarmak-nv approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@jarmak-nv jarmak-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

On my personal machine:

  • Old method: 23.6s
  • This method: 1.9s

🎉

@isVoid
Copy link
Contributor Author

isVoid commented May 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit 5829c49 into rapidsai:branch-23.06 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@jarmak-nv jarmak-nv jarmak-nv approved these changes

@thomcom thomcom Awaiting requested review from thomcom

Assignees

@isVoid isVoid

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isVoid @harrism @jarmak-nv