Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header only API for polygon-polygon distance #1065

Merged
merged 15 commits into from
Apr 26, 2023
Merged

Header only API for polygon-polygon distance #1065

merged 15 commits into from
Apr 26, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Apr 10, 2023 •
edited
Loading

Description

This PR contains 2 major additions:

  1. Range casting methods. Developer can now cast a multipolygon_range to a multilinestring_range or a multipoint_range. This change is included in multipolygon_range.cuh and multipolygon_range_test.cu.
  2. Pairwise polygon-polygon distance. This change is separated in two parts:
    1. linestring-linestring compute kernel is refactored into algorithm/linetring_distance.cuh.
    2. This kernel is then reused to compute polygon ring distances.

Closes #1052

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner April 10, 2023 20:27
@isVoid isVoid requested review from trxcllnt and harrism April 10, 2023 20:27
@isVoid isVoid marked this pull request as draft April 10, 2023 20:27
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Apr 10, 2023
@isVoid isVoid changed the title Header only API for polygon-polygon distance [skip-ci] Header only API for polygon-polygon distance Apr 10, 2023
@isVoid isVoid self-assigned this Apr 10, 2023
@github-actions github-actions bot added the cmake Related to CMake code or build configuration label Apr 11, 2023
@isVoid isVoid marked this pull request as ready for review April 11, 2023 22:50
@isVoid isVoid requested a review from a team as a code owner April 11, 2023 22:50
@isVoid isVoid changed the title [skip-ci] Header only API for polygon-polygon distance Header only API for polygon-polygon distance Apr 11, 2023
isVoid
isVoid commented Apr 11, 2023
View reviewed changes
cpp/tests/experimental/spatial/polygon_distance_test.cu Outdated
{2.0, 2.0},
{3.0, 3.0}},
{1, 0});
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have experimented to create some machinery to test the combinations more efficiently, instead of fully by manual here. But since I'm very down the road making these tests, I'll punt them to later.

@isVoid isVoid added 3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change labels Apr 11, 2023
@isVoid isVoid mentioned this pull request Apr 13, 2023
Merged
3 tasks
@isVoid isVoid mentioned this pull request Apr 25, 2023
Open
@isVoid
Copy link
Contributor Author

isVoid commented Apr 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit 5269685 into rapidsai:branch-23.06 Apr 26, 2023
rapids-bot bot pushed a commit that referenced this pull request May 2, 2023
@isVoid
Column API for pairwise_polygon_distance (#1073)
2d02073 
This PR adds column API for `pairwise_polygon_distance`.

This PR also adds `CUSPATIAL_HOST_DEVICE_EXPECTS` macro to help error assertion in `__host__ __device__` functions.

closes #1053 

depends on #1065

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Mark Harris (https://github.com/harrism)

URL: #1073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration feature request New feature or request libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header Only API Polygon-Polygon Distance
2 participants
@isVoid @harrism