Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cuSpatial: Build CUDA 12 packages #1044
cuSpatial: Build CUDA 12 packages #1044
Changes from all commits
d6abd8d
faaec0c
27a4ae9
011f1b5
9e22857
6b8e198
b17dc52
26faa51
01b5c6b
b878052
362535d
4be8e48
93db8af
7a34966
ded69e2
7e0e324
96b046e
1b948db
4f65bce
24b58ba
2a47eed
5b48690
98e0d45
2ad9a11
c0d5d7a
6296179
121552b
0699874
990354f
2258168
f66f8b8
6122002
72e3267
171b964
d31c795
20e175f
4f2e4ad
c99105f
f6cdb0e
566cda0
e3faf15
640399a
baee048
5b6372d
cbd9ac1
d2a20f9
2e7120a
1688b39
1264b1f
0e55484
7e8363b
bff32db
cb3fb6f
b2a5d4a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have the compilers here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we have already finished compilation by the time we're packaging libcuspatial and libcuspatial-tests. Compilers are needed in the top-level
build
section for use bybuild.sh
, but the individual package outputs only install (copy) files to the conda environment and do not perform compilation.The only argument I could see for adding compilers would be to influence the host/run environments via
run_exports
but I think that is not necessary here (we haven't traditionally done this).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need
ninja
here too (as it is used elsewhere)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we do not need ninja here. Ninja should be in the top-level
build
but not the subpackages'build
sections.