Skip to content

Commit

Permalink
Add author credit to zipcode counting notebook, fix cudf string proce…
Browse files Browse the repository at this point in the history
…ssing argument (#1201)

This PR fixes the usage of a small cudf string processing method. `regex` should be set to false for `.str.split` without
regex delimiter. In addition, adds credit to authors.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)

URL: #1201
  • Loading branch information
isVoid authored Jun 26, 2023
1 parent b047c6a commit 3da3332
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions notebooks/ZipCodes_Stops_PiP_cuSpatial.ipynb
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
{
"cells": [
{
"attachments": {},
"cell_type": "markdown",
"id": "458fe838-b143-4d31-9ddd-8efd0217f4a7",
"metadata": {},
"source": [
"# Stop Sign Counting By Zipcode in California"
"# Stop Sign Counting By Zipcode in California\n",
"\n",
"Author: Everett Spackman, Michael Wang, Thomson Comer, Ben Jarmak"
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "6931011f-0d83-45ce-b254-4b5424b82624",
"metadata": {},
Expand Down Expand Up @@ -59,6 +63,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "497810f3-acf0-4472-a187-322413c9db11",
"metadata": {},
Expand Down Expand Up @@ -108,6 +113,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "044c84d9-2f82-4de5-a4c5-b7b9e5ef6b93",
"metadata": {},
Expand Down Expand Up @@ -144,6 +150,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "50b8d8bc-378f-4faa-b60c-e8f0ff507b2a",
"metadata": {},
Expand All @@ -170,6 +177,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "6fdaedfc-2d7f-4d73-a9b8-e3a8131bea2f",
"metadata": {},
Expand Down Expand Up @@ -221,7 +229,7 @@
" # split polygons into rings\n",
" wkts, num_rings = traverse(wkts, \"\\),\\s?\\(\", regex=True)\n",
" # split coordinates into lists\n",
" wkts, num_coords = traverse(wkts, \",\", regex=True)\n",
" wkts, num_coords = traverse(wkts, \",\")\n",
" # split into x-y coordinates\n",
" wkts = wkts.str.split(\" \")\n",
" wkts = wkts.explode().astype(cp.dtype(dtype))\n",
Expand Down Expand Up @@ -400,6 +408,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "eda8fb4c-39ec-44e2-9163-cbbdd91eeb1d",
"metadata": {},
Expand Down Expand Up @@ -468,6 +477,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "ab387f5a-cf7e-49d4-b3c8-c5b4b059cd4d",
"metadata": {},
Expand All @@ -476,6 +486,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "6446d81b-006a-4a0b-995b-a001c9b7766f",
"metadata": {},
Expand Down Expand Up @@ -604,6 +615,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "4b61f534-faa4-4465-b47b-fb717169f30e",
"metadata": {},
Expand Down Expand Up @@ -668,6 +680,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "d1f2af42-affb-4e9e-ac24-b5583641a366",
"metadata": {},
Expand Down Expand Up @@ -734,6 +747,7 @@
]
},
{
"attachments": {},
"cell_type": "markdown",
"id": "e05fc526-c935-417f-9f53-0f13a0c6d02a",
"metadata": {},
Expand Down

0 comments on commit 3da3332

Please sign in to comment.