Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cudf from libcuml meta.yaml #5407

Merged
merged 1 commit into from
May 9, 2023
Merged

Remove cudf from libcuml meta.yaml #5407

merged 1 commit into from
May 9, 2023

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented May 9, 2023 •
edited
Loading

libcuml does not have a dependency on cudf, and this was just present due to legacy reasons.

@divyegala divyegala added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 9, 2023
@divyegala divyegala self-assigned this May 9, 2023
@divyegala divyegala requested a review from a team as a code owner May 9, 2023 14:58
@github-actions github-actions bot added the conda conda issue label May 9, 2023
ajschmidt8
ajschmidt8 reviewed May 9, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divyegala, can you add a description to your PR body describing why these changes were made?

@divyegala
Copy link
Member Author

can you add a description to your PR body describing why these changes were made?

@ajschmidt8 done

@divyegala
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit d616c1c into rapidsai:branch-23.06 May 9, 2023
bdice
bdice reviewed May 9, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is missing librmm as a dependency, though. I'll add a PR to fix that.

@bdice bdice mentioned this pull request May 9, 2023
Merged
rapids-bot bot pushed a commit that referenced this pull request May 10, 2023
@bdice
Add librmm to libcuml dependencies. (#5410)
93015b9 
Following up on #5407 (review) to add a missing dependency from `libcuml` on `librmm`.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #5410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@ajschmidt8 ajschmidt8 ajschmidt8 left review comments

@dantegd dantegd dantegd approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@divyegala divyegala

Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@divyegala @dantegd @raydouglass @bdice @ajschmidt8