Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MANIFEST.in use auto-generated one for sdists and package_data for wheels #5278

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 16, 2023

Using MANIFEST.in currently runs into a pretty nasty scikit-build bug (scikit-build/scikit-build#886) that results in any file included by the manifest being copied from the install tree back into the source tree whenever an in place build occurs after an install, overwriting any local changes. We need an alternative approach to ensure that all necessary files are included in built packages. There are two types:

  • sdists: scikit-build automatically generates a manifest during sdist generation if we don't provide one, and that manifest is reliably complete. It contains all files needed for a source build up to the cuml C++ code (which has always been true and is something we can come back to improving later if desired).
  • wheels: The autogenerated manifest is not used during wheel generation because the manifest generation hook is not invoked during wheel builds, so to include data in the wheels we must provide the package_data argument to setup. In this case we do not need to include CMake or pyx files because the result does not need to be possible to build from, it just needs pxd files for other packages to cimport if desired.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Mar 16, 2023
@vyasr vyasr self-assigned this Mar 16, 2023
@vyasr vyasr requested review from a team as code owners March 16, 2023 21:16
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 16, 2023
@dantegd
Copy link
Member

dantegd commented Mar 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit e645fae into rapidsai:branch-23.04 Mar 17, 2023
@vyasr vyasr deleted the fix/manifest branch March 21, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants