Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate pyproject dependencies with dfg #5275

Merged
merged 12 commits into from
Mar 28, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 15, 2023

This PR uses dependencies.yaml to generate the dependency lists in pyproject.toml

@vyasr vyasr added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 15, 2023
@vyasr vyasr self-assigned this Mar 15, 2023
@vyasr vyasr requested review from a team as code owners March 15, 2023 14:28
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Mar 15, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Mar 15, 2023

I left a few questions as inline comments but will replicate them here for convenience:

  • Some of the runtime requirements like seaborn and scipy seem like they could be optional, but I don't know if that's of interest to the cuml devs right now. There are enough conditional imports happening in the package that I couldn't sort through all of them. seaborn and scipy were particular examples that seemed like they could plausibly be optional.
  • The hdbscan packages on conda-forge and pypi are getting out of sync. The pypi package is no longer that out of date (there was a release in October) but the conda-forge package is now quite old due to pulling from a fork instead of the main repo. Do we need to take any action here? Does dependencies.yaml need to stay bifurcated, or can we simply pull the package using the name in both cases and move on now?
  • Is there a plan for dask-glm since the repo is archived now?

@vyasr
Copy link
Contributor Author

vyasr commented Mar 21, 2023

/merge

@vyasr vyasr requested a review from raydouglass March 23, 2023 21:15
@rapids-bot rapids-bot bot merged commit 1a9dd32 into rapidsai:branch-23.04 Mar 28, 2023
@vyasr vyasr deleted the feat/pyproject_dependencies branch March 28, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants