Use ivf_pq and ivf_flat from raft #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfred
changed the title
cjnolet
added
improvement
dantegd
added
breaking
|
Added breaking label due to the removal of |
Codecov ReportBase: 69.63% // Head: 69.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #5119 +/- ##
================================================
- Coverage 69.63% 69.12% -0.51%
================================================
Files 192 192
Lines 12523 12333 -190
================================================
- Hits 8720 8525 -195
- Misses 3803 3808 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/merge |
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
We are removing the faiss ANN code in rapidsai/raft#1121, in favour of using the ivf_flat and ivf_pq implementations included with raft. After this change, RAFT can be updated to remove the faiss ANN methods - which is implemented in rapidsai/raft#1121 Note that this removes the `ivf_sq` option , since there is no corresponding implementation in raft. Closes rapidsai#5131 Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#5119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing the faiss ANN code in rapidsai/raft#1121, in favour of
using the ivf_flat and ivf_pq implementations included with raft.
After this change, RAFT can be updated to remove the faiss ANN methods - which is implemented in
rapidsai/raft#1121
Note that this removes the
ivf_sqoption , since there is no corresponding implementation in raft.Closes #5131