-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose text, text.{CountVectorizer,HashingVectorizer,Tfidf{Transformer,Vectorizer}} from feature_extraction's public api #5028
Conversation
…r,Vectorizer}} from feature_extraction's public api
@mattf Is this a hotfix or should it be targeting branch-23.02 ? |
@csadorf i don’t think this is a hotfix. this is on 22.12 because the default branch is branch-22.12. |
Got it. 👍🏻 cuml is already in the burn down stage, so I'd suggest to target branch-23.02. |
@csadorf the ci failures look unrelated to this pr |
rerun tests |
@gpucibot merge |
rerun tests |
Same comment as PR #5034, for some reason the branch checker job is stuck in a couple of PRs, will work on solving that or admin merging later today |
Codecov ReportBase: 79.38% // Head: 79.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #5028 +/- ##
================================================
+ Coverage 79.38% 79.83% +0.44%
================================================
Files 184 185 +1
Lines 11707 11728 +21
================================================
+ Hits 9294 9363 +69
+ Misses 2413 2365 -48
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@dantegd can you trigger the branch checker by updating the PR title, please? |
@gpucibot merge |
…r,Vectorizer}} from feature_extraction's public api (rapidsai#5028) Authors: - Matthew Farrellee (https://github.com/mattf) Approvers: - Carl Simon Adorf (https://github.com/csadorf) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#5028
No description provided.