Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single-GPU build by separating multi-GPU decomposition utils from single GPU #4645

Merged
merged 6 commits into from
Mar 30, 2022
Merged

Fix single-GPU build by separating multi-GPU decomposition utils from single GPU #4645

merged 6 commits into from
Mar 30, 2022

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Mar 22, 2022 •
edited
Loading

Fixes single GPU build by dividing decomposition pxd headers so that cumlprims files are not included in single GPU cython files.

@dantegd dantegd added bug Something isn't working 2 - In Progress Currenty a work in progress non-breaking Non-breaking change labels Mar 22, 2022
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 22, 2022
@dantegd dantegd mentioned this pull request Mar 24, 2022
Closed
@canonizer canonizer mentioned this pull request Mar 28, 2022
Merged
@dantegd dantegd marked this pull request as ready for review March 30, 2022 15:42
@dantegd dantegd requested a review from a team as a code owner March 30, 2022 15:42
@dantegd dantegd changed the title Fix single-GPU build by separating multi-GPU decomposition utils from single GPU [skip-ci] Fix single-GPU build by separating multi-GPU decomposition utils from single GPU Mar 30, 2022
@dantegd
Copy link
Member Author

dantegd commented Mar 30, 2022

rerun tests

cjnolet
cjnolet approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the conda conda issue label Mar 30, 2022
ajschmidt8
ajschmidt8 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@dantegd dantegd requested a review from a team as a code owner March 30, 2022 18:23
ajschmidt8
ajschmidt8 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@6b72323). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.04    #4645   +/-   ##
===============================================
  Coverage                ?   83.97%           
===============================================
  Files                   ?      252           
  Lines                   ?    20336           
  Branches                ?        0           
===============================================
  Hits                    ?    17078           
  Misses                  ?     3258           
  Partials                ?        0
Flag Coverage Δ
dask 44.98% <0.00%> (?)
non-dask 77.26% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b72323...03c27a5. Read the comment docs.

@dantegd
Copy link
Member Author

dantegd commented Mar 30, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3cf4eb1 into rapidsai:branch-22.04 Mar 30, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Fix single-GPU build by separating multi-GPU decomposition utils from…
42f89dd 
… single GPU (rapidsai#4645)

Fixes single GPU build by dividing decomposition pxd headers so that cumlprims files are not included in single GPU cython files.

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#4645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
2 - In Progress Currenty a work in progress bug Something isn't working conda conda issue Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantegd @codecov-commenter @cjnolet @ajschmidt8