Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to build RAFT artifacts statically into libcuml++ #4633

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Add option to build RAFT artifacts statically into libcuml++ #4633

merged 3 commits into from
Mar 15, 2022

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Mar 15, 2022

Add explicit option similar to FAISS and Treelite to be able to build a single libcuml++ with all RAFT binary dependencies.

@dantegd dantegd added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 15, 2022
@dantegd dantegd requested a review from a team as a code owner March 15, 2022 16:33
cjnolet
cjnolet approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@05a9c16). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.04    #4633   +/-   ##
===============================================
  Coverage                ?   83.85%           
===============================================
  Files                   ?      251           
  Lines                   ?    20282           
  Branches                ?        0           
===============================================
  Hits                    ?    17007           
  Misses                  ?     3275           
  Partials                ?        0
Flag Coverage Δ
dask 44.93% <0.00%> (?)
non-dask 77.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a9c16...93d4611. Read the comment docs.

@dantegd
Copy link
Member Author

dantegd commented Mar 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 88ec85e into rapidsai:branch-22.04 Mar 15, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Add option to build RAFT artifacts statically into libcuml++ (rapidsa…
0a109f8 
…i#4633)

Add explicit option similar to FAISS and Treelite to be able to build a single `libcuml++` with all RAFT binary dependencies.

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantegd @codecov-commenter @cjnolet