Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Treelite to 2.3.0 #4590

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Conversation

@hcho3 hcho3 requested review from a team as code owners February 19, 2022 01:16
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ gpuCI gpuCI issue labels Feb 19, 2022
@hcho3 hcho3 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 19, 2022
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rapidsai/integration#436 was merged. Once those changes are propagated, we can proceed with this PR.

@github-actions github-actions bot removed the gpuCI gpuCI issue label Feb 22, 2022
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wphicks wphicks requested a review from ajschmidt8 February 22, 2022 19:51
@wphicks
Copy link
Contributor

wphicks commented Feb 22, 2022

Deleted my merge comment because I realized this needed re-review from ops

@dantegd
Copy link
Member

dantegd commented Feb 22, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@cbe4beb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4590   +/-   ##
===============================================
  Coverage                ?   83.88%           
===============================================
  Files                   ?      250           
  Lines                   ?    20061           
  Branches                ?        0           
===============================================
  Hits                    ?    16829           
  Misses                  ?     3232           
  Partials                ?        0           
Flag Coverage Δ
dask 45.17% <0.00%> (?)
non-dask 76.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe4beb...3cc3cb3. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Feb 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b8bc665 into rapidsai:branch-22.04 Feb 22, 2022
@hcho3 hcho3 deleted the upgrade_treelite branch February 23, 2022 00:04
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
The 2.3.0 version of Treelite incorporates the following improvements:
* GTIL optimization using multiple CPU threads (dmlc/treelite#353, dmlc/treelite#355, dmlc/treelite#357, dmlc/treelite#358, dmlc/treelite#362, dmlc/treelite#367)
* dmlc/treelite#365
* dmlc/treelite#366
* dmlc/treelite#368

Requires rapidsai/integration#436

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#4590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake conda conda issue CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants