Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Changes required in cuML corresponding to RAFT RNG improvements #4562

Closed

Conversation

vinaydes
Copy link
Contributor

@vinaydes vinaydes commented Feb 7, 2022

This PR lists changes needed in cuML corresponding to RAFT RNG improvements PR #434.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 9, 2022
@cjnolet
Copy link
Member

cjnolet commented Feb 10, 2022

rerun tests

@vinaydes
Copy link
Contributor Author

The nearest neighbour test failure seems to be unrelated to this PR or the RAFT RNG PR. As is noted in the comments inside the test, this test seems to fail intermittently. Link to the issue #4262
Two observations I made so far

  • The test seems to pass when alternate seed is used.
  • In this line, the values in rbc_d seems to change between pass and fail scenario of the test.
    I'll investigate a little more on it.

@cjnolet
Copy link
Member

cjnolet commented Feb 10, 2022

@vinaydes, it looks like we have a tolerance of 1 mismatched element but it's failing w/ 2. I'm okay increasing that tolerance to 2 for the time being.

@vinaydes vinaydes requested a review from a team as a code owner February 10, 2022 20:55
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 10, 2022
@cjnolet
Copy link
Member

cjnolet commented Feb 11, 2022

rerun tests

@github-actions github-actions bot removed the CMake label Feb 11, 2022
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Feb 11, 2022

@gpucibot merge

@vinaydes
Copy link
Contributor Author

Thanks, Corey. I'll update the bug related to failing unit test with my findings so far for any future debugging effort.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@1dd32dc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4562   +/-   ##
===============================================
  Coverage                ?   83.87%           
===============================================
  Files                   ?      250           
  Lines                   ?    20070           
  Branches                ?        0           
===============================================
  Hits                    ?    16833           
  Misses                  ?     3237           
  Partials                ?        0           
Flag Coverage Δ
dask 45.18% <0.00%> (?)
non-dask 76.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd32dc...85da579. Read the comment docs.

@cjnolet
Copy link
Member

cjnolet commented Feb 11, 2022

rerun tests

@cjnolet cjnolet closed this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants