-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Changes required in cuML corresponding to RAFT RNG improvements #4562
[WIP] Changes required in cuML corresponding to RAFT RNG improvements #4562
Conversation
…p_label_cluster_spectral_updates
…tral_updates' into for-raft-rng-improvements
rerun tests |
The nearest neighbour test failure seems to be unrelated to this PR or the RAFT RNG PR. As is noted in the comments inside the test, this test seems to fail intermittently. Link to the issue #4262
|
@vinaydes, it looks like we have a tolerance of 1 mismatched element but it's failing w/ 2. I'm okay increasing that tolerance to 2 for the time being. |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gpucibot merge |
Thanks, Corey. I'll update the bug related to failing unit test with my findings so far for any future debugging effort. |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #4562 +/- ##
===============================================
Coverage ? 83.87%
===============================================
Files ? 250
Lines ? 20070
Branches ? 0
===============================================
Hits ? 16833
Misses ? 3237
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
rerun tests |
This PR lists changes needed in cuML corresponding to RAFT RNG improvements PR #434.