Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xgboost version in CI #4541

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Update xgboost version in CI #4541

merged 3 commits into from
Feb 2, 2022

Conversation

ajschmidt8
Copy link
Member

This PR updates the xgboost version in CI. It also removes a dead code block from when we supported Python version 3.6.

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2022
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner January 31, 2022 19:13
@github-actions github-actions bot added the gpuCI gpuCI issue label Jan 31, 2022
AyodeAwe
AyodeAwe approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@AyodeAwe AyodeAwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajschmidt8
Copy link
Member Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@a70044c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 15951e5 differs from pull request most recent head 4fa7eb3. Consider uploading reports for the commit 4fa7eb3 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4541   +/-   ##
===============================================
  Coverage                ?   85.71%           
===============================================
  Files                   ?      236           
  Lines                   ?    19365           
  Branches                ?        0           
===============================================
  Hits                    ?    16599           
  Misses                  ?     2766           
  Partials                ?        0
Flag Coverage Δ
dask 46.48% <0.00%> (?)
non-dask 78.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70044c...4fa7eb3. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Feb 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6d2073b into rapidsai:branch-22.04 Feb 2, 2022
@ajschmidt8 ajschmidt8 deleted the update-xgboost branch February 2, 2022 02:00
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@ajschmidt8
Update xgboost version in CI (rapidsai#4541)
e098c2e 
This PR updates the `xgboost` version in CI. It also removes a dead code block from when we supported Python version `3.6`.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Jordan Jacobelli (https://github.com/Ethyling)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees
No one assigned
Labels
gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajschmidt8 @codecov-commenter @dantegd @jjacobelli @AyodeAwe