Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Pin dask & distributed #4505

Merged
merged 1 commit into from
Jan 25, 2022
Merged

[REVIEW] Pin dask & distributed #4505

merged 1 commit into from
Jan 25, 2022

Conversation

galipremsagar
Copy link
Contributor

Changed to be in-line with: rapidsai/cudf#10108

@galipremsagar galipremsagar requested a review from a team as a code owner January 23, 2022 01:08
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Jan 23, 2022
@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Jan 23, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@5df7010). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4505   +/-   ##
===============================================
  Coverage                ?   85.69%           
===============================================
  Files                   ?      236           
  Lines                   ?    19326           
  Branches                ?        0           
===============================================
  Hits                    ?    16562           
  Misses                  ?     2764           
  Partials                ?        0
Flag Coverage Δ
dask 46.52% <0.00%> (?)
non-dask 78.59% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df7010...886ec5b. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Jan 24, 2022

rerun tests

@ajschmidt8
Copy link
Member

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor Author

rerun tests

@jakirkham
Copy link
Member

rerun tests

(looks like one of the jobs hung during compilation)

@ajschmidt8
Copy link
Member

There were a few pipelines running in parallel for this job and effecting the GH Check statuses. I

@ajschmidt8 ajschmidt8 closed this Jan 24, 2022
@ajschmidt8 ajschmidt8 reopened this Jan 24, 2022
@ajschmidt8
Copy link
Member

ajschmidt8 commented Jan 24, 2022 •
edited
Loading

(didn't mean to close this)

There were a few pipelines running in parallel for this PR which was affecting the GitHub statuses. I canceled all the others and started a new one.

@dantegd
Copy link
Member

dantegd commented Jan 25, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Jan 25, 2022

@gpucibot merge

1 similar comment
@jjacobelli
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2cc2d69 into rapidsai:branch-22.02 Jan 25, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@galipremsagar
Pin dask & distributed (rapidsai#4505)
8030efd 
Changed to be in-line with: rapidsai/cudf#10108

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working conda conda issue gpuCI gpuCI issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@galipremsagar @codecov-commenter @dantegd @ajschmidt8 @jakirkham @jjacobelli @cjnolet