Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring for npermutations in PermutationExplainer #4402

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Fix docstring for npermutations in PermutationExplainer #4402

merged 1 commit into from
Dec 6, 2021

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Nov 24, 2021

Closes #4047

@hcho3 hcho3 requested a review from a team as a code owner November 24, 2021 02:17
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 24, 2021
@hcho3 hcho3 added doc Documentation non-breaking Non-breaking change labels Nov 24, 2021
@dantegd dantegd closed this Dec 5, 2021
@dantegd dantegd reopened this Dec 5, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@ed0e58c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4402   +/-   ##
===============================================
  Coverage                ?   85.73%           
===============================================
  Files                   ?      236           
  Lines                   ?    19314           
  Branches                ?        0           
===============================================
  Hits                    ?    16558           
  Misses                  ?     2756           
  Partials                ?        0
Flag Coverage Δ
dask 46.52% <0.00%> (?)
non-dask 78.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0e58c...8b6a16e. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Dec 6, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3c36f62 into rapidsai:branch-22.02 Dec 6, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@hcho3
Fix docstring for npermutations in PermutationExplainer (rapidsai#4402)
ab2990d 
Closes rapidsai#4047

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] shap explainer npermutations is documented wrongly
3 participants
@hcho3 @codecov-commenter @dantegd