Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forward merge #4349 [skip-ci] #4374

Merged
merged 8 commits into from
Nov 17, 2021
Merged

Fix forward merge #4349 [skip-ci] #4374

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37915ae
Update `CUDA` Flags [skip ci] (#4343)
ajschmidt8 Nov 10, 2021
fcc4344
Fix potential CUDA context poison when negative (invalid) categories …
levsnv Nov 10, 2021
6885d39
fix stable logic (#4347)
ajschmidt8 Nov 10, 2021
f3be1b0
Mark Hellinger sparse test as xfail
wphicks Nov 11, 2021
0a891f6
Add missing keyword to xfail mark
wphicks Nov 11, 2021
37c8e81
Fix style
wphicks Nov 11, 2021
69621b8
Merge pull request #4355 from wphicks/bug-xfail_hellinger
jjacobelli Nov 11, 2021
5d81fc5
FIX Fix conflicts of forward merger
dantegd Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/cmake/modules/ConfigureCUDA.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ list(APPEND CUML_CUDA_FLAGS --expt-extended-lambda --expt-relaxed-constexpr)
if(CMAKE_CUDA_COMPILER_VERSION VERSION_GREATER_EQUAL 11.2.0)
list(APPEND CUML_CUDA_FLAGS -Werror=all-warnings)
endif()
list(APPEND CUML_CUDA_FLAGS -Xcompiler=-Wall,-Werror,-Wno-error=deprecated-declarations)
list(APPEND CUML_CUDA_FLAGS -Xcompiler=-Wall,-Werror,-Wno-error=deprecated-declarations,-Wno-error=sign-compare)

if(DISABLE_DEPRECATION_WARNING)
list(APPEND CUML_CXX_FLAGS -Wno-deprecated-declarations)
Expand Down