Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RAFT template instantations for distances #4302

Merged
merged 42 commits into from
Dec 16, 2021
Merged

Use RAFT template instantations for distances #4302

merged 42 commits into from
Dec 16, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Oct 21, 2021

No description provided.

@cjnolet cjnolet requested review from a team as code owners October 21, 2021 23:43
@cjnolet cjnolet added 2 - In Progress Currenty a work in progress CUDA / C++ CUDA issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 22, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Dec 8, 2021

rerun tests

3 similar comments
@cjnolet
Copy link
Member Author

cjnolet commented Dec 10, 2021

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Dec 10, 2021

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Dec 10, 2021

rerun tests

@github-actions github-actions bot added the gpuCI gpuCI issue label Dec 14, 2021
@dantegd
Copy link
Member

dantegd commented Dec 14, 2021

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Dec 14, 2021

rerun tests

1 similar comment
@ajschmidt8
Copy link
Member

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Dec 14, 2021

rerun tests

@cjnolet cjnolet added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Dec 15, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Dec 15, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@9046f85). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4302   +/-   ##
===============================================
  Coverage                ?   85.72%           
===============================================
  Files                   ?      236           
  Lines                   ?    19326           
  Branches                ?        0           
===============================================
  Hits                    ?    16568           
  Misses                  ?     2758           
  Partials                ?        0
Flag Coverage Δ
dask 46.51% <0.00%> (?)
non-dask 78.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9046f85...38b757b. Read the comment docs.

@cjnolet
Copy link
Member Author

cjnolet commented Dec 16, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fed3774 into rapidsai:branch-22.02 Dec 16, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Use RAFT template instantations for distances (rapidsai#4302)
6b3760c 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: rapidsai#4302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@dantegd dantegd dantegd approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team CMake CUDA / C++ CUDA issue CUDA/C++ Cython / Python Cython or Python issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjnolet @ajschmidt8 @dantegd @codecov-commenter @jjacobelli @divyegala