-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split C++ tests into separate binaries #4295
Conversation
This PR has been labeled |
rerun tests |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ops-codeowner
file changes
test_name=$(basename $gt) | ||
echo "Patching gtest $test_name" | ||
chrpath -d ${gt} | ||
patchelf --replace-needed `patchelf --print-needed ${gt} | grep faiss` libfaiss.so ${gt} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR, but why do we need to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #4295 +/- ##
===============================================
Coverage ? 83.88%
===============================================
Files ? 250
Lines ? 20052
Branches ? 0
===============================================
Hits ? 16820
Misses ? 3232
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@gpucibot merge |
Depends on #4295 PR allows `libcuml++` to be built with individual algorithms, or individual families of algorithms with the argument `CUML_ALGORITHMS`. It defaults to `ALL`, and can take multiple options like: ``` cmake .. -DCUML_ALGORITHMS="FIL;TREESHAP" ``` which will build a `libcuml++` only containing FIL and GPUTreeSHAP components. PR to update build documentation will follow up. Authors: - Dante Gama Dessavre (https://github.com/dantegd) - Divye Gala (https://github.com/divyegala) Approvers: - William Hicks (https://github.com/wphicks) - Corey J. Nolet (https://github.com/cjnolet) URL: #4296
Closes rapidsai#4104 Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Jordan Jacobelli (https://github.com/Ethyling) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4295
Depends on rapidsai#4295 PR allows `libcuml++` to be built with individual algorithms, or individual families of algorithms with the argument `CUML_ALGORITHMS`. It defaults to `ALL`, and can take multiple options like: ``` cmake .. -DCUML_ALGORITHMS="FIL;TREESHAP" ``` which will build a `libcuml++` only containing FIL and GPUTreeSHAP components. PR to update build documentation will follow up. Authors: - Dante Gama Dessavre (https://github.com/dantegd) - Divye Gala (https://github.com/divyegala) Approvers: - William Hicks (https://github.com/wphicks) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4296
Closes #4104