-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add option to build faiss and treelite shared libs, inherit common dependencies from raft #4256
[FEA] Add option to build faiss and treelite shared libs, inherit common dependencies from raft #4256
Conversation
…nstall export-set
…d the targets to a build export-set
rerun tests |
…om:shwina/cuml into fix/build-shared-faiss
rerun tests |
rerun tests |
Darn. It looks like even though we are using the cucollections patch that depends on thrust 1.15, CI in cuml is still pulling in thrust 1.12 from somewhere. I’m wondering if it’s something within cuML’s dependencies which is doing this (such as cumlprims_mg maybe?) since the RAFT side seems to be properly using thrust 1.15 (as evidenced in this CI log) |
@trxcllnt and I finally figured out that there are conflicting versions of thrust being pulled in, which are causing the issues w/ the |
I am reading the CI logs to be that Thrust 1.12 exists in the conda env, and therefore causing the mismatch issue for cuml.
I believe this as |
rerun tests |
2 similar comments
rerun tests |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #4256 +/- ##
===============================================
Coverage ? 85.69%
===============================================
Files ? 236
Lines ? 19326
Branches ? 0
===============================================
Hits ? 16562
Misses ? 2764
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@gpucibot merge |
…pendencies from raft (rapidsai#4256) Depends on rapidsai/raft#345, and CI will be blocked until `raft` is removed from `libcumlprims` install export set. Authors: - Paul Taylor (https://github.com/trxcllnt) - Divye Gala (https://github.com/divyegala) - Ashwin Srinath (https://github.com/shwina) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4256
Depends on rapidsai/raft#345, and CI will be blocked until
raft
is removed fromlibcumlprims
install export set.