Add Multinomial and Bernoulli Naive Bayes variants #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: python/cuml/naive_bayes/naive_bayes.py
…parts that do work.
…when fitting all classes at once instead of one at a time.
… little differently than sklearn
cjnolet
requested changes
Jul 16, 2021
| from cuml.common.kernel_utils import cuda_kernel_factory | ||
|
|
||
|
|
||
| def _binarize_kernel(x_dtype): |
There was a problem hiding this comment.
Not something that has to be fixed in this PR since it's being used everywhere already, but CuPy now supports writing kernels with template arguments so we should be able to remove the use of the cuda_kernel_factory everywhere in the codebase. It should also make our kernel invocations look much more clean.
|
Here are comparison of cuML and SKLearn performance on Multinomial and Bernoulli NB. Multinomial Bernoulli |
cjnolet
approved these changes
Jul 20, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #4053 +/- ##
===============================================
Coverage ? 85.77%
===============================================
Files ? 231
Lines ? 18261
Branches ? 0
===============================================
Hits ? 15664
Misses ? 2597
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 9, 2021
This is a continuation of PR #1763 and #4053, to add Gaussian Naive Bayes. This is supposed to be merged after #4053 Here is a comparison of cuML and SKLearn performance on Gaussian NB. This is done using a synthetic dataset generated by make_regression. The GPU used is a RTX 8000, and the CPU is i9-10920X @ 3.50GHz  Linking issue #1666 Authors: - Micka (https://github.com/lowener) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #4079
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
This is a continuation of PR #1763, #4053, and #4079, to add Categorical Naive Bayes. This is supposed to be merged after #4079. Linking issue #1666. Authors: - Micka (https://github.com/lowener) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #4150
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This is a continuation of PR rapidsai#1763, to add Multinomial and Bernoulli NB variants. The Gaussian and Categorical variants will be added in a following PR. Also linking issue rapidsai#1666 Authors: - Micka (https://github.com/lowener) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4053
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This is a continuation of PR rapidsai#1763 and rapidsai#4053, to add Gaussian Naive Bayes. This is supposed to be merged after rapidsai#4053 Here is a comparison of cuML and SKLearn performance on Gaussian NB. This is done using a synthetic dataset generated by make_regression. The GPU used is a RTX 8000, and the CPU is i9-10920X @ 3.50GHz  Linking issue rapidsai#1666 Authors: - Micka (https://github.com/lowener) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4079
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This is a continuation of PR rapidsai#1763, rapidsai#4053, and rapidsai#4079, to add Categorical Naive Bayes. This is supposed to be merged after rapidsai#4079. Linking issue rapidsai#1666. Authors: - Micka (https://github.com/lowener) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #1763, to add Multinomial and Bernoulli NB variants.
The Gaussian and Categorical variants will be added in a following PR.
Also linking issue #1666