[FIX] Add treelite include paths to treelite targets #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
approved these changes
Jul 1, 2021
| if(Treelite_ADDED AND NOT TARGET treelite::treelite_static) | ||
| add_library(treelite::treelite_static ALIAS treelite_static) | ||
| add_library(treelite::treelite_runtime_static ALIAS treelite_runtime_static) | ||
| if(Treelite_ADDED) |
There was a problem hiding this comment.
Should this be made not conditional on treelite as we were talking about offline?
There was a problem hiding this comment.
Turns out Treelite_SOURCE_DIR and Treelite_BINARY_DIR aren't populated if Treelite_ADDED is false.
|
rerun tests |
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #4023 +/- ##
===============================================
Coverage ? 85.46%
===============================================
Files ? 230
Lines ? 18133
Branches ? 0
===============================================
Hits ? 15498
Misses ? 2635
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Follow-up to rapidsai#4018, but this time it actually works. Makes `${Treelite_SOURCE_DIR}/include` part of the build interface so users consuming an installed `cuml++` don't get an include path to the build dir. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4018, but this time it actually works.
Makes
${Treelite_SOURCE_DIR}/includepart of the build interface so users consuming an installedcuml++don't get an include path to the build dir.