[REVIEW] Use chebyshev, canberra, hellinger and minkowski distance metrics #3990
Conversation
…m raft. update test_metrics pytest accordingly
cpp/cmake/thirdparty/get_raft.cmake
Outdated
| @@ -44,6 +44,6 @@ set(CUML_BRANCH_VERSION_raft "${CUML_VERSION_MAJOR}.${CUML_VERSION_MINOR}") | |||
| # To use a different RAFT locally, set the CMake variable | |||
| # CPM_raft_SOURCE=/path/to/local/raft | |||
| find_and_configure_raft(VERSION ${CUML_MIN_VERSION_raft} | |||
| FORK rapidsai | |||
| PINNED_TAG branch-${CUML_BRANCH_VERSION_raft} | |||
| FORK mdoijade | |||
There was a problem hiding this comment.
Just a note here to refert this once merged
cjnolet
added
2 - In Progress
mdoijade
changed the title
|
@dantegd why are these CI tests stuck since days? can you please rerun test? |
|
rerun tests |
|
@mdoijade is there something in this PR or the RAFT one that increases compile times dramatically? The CI log once again timed out during compilation, I haven't seen it happen in any other PR (will keep an eye on that), so it might be something particular to the changes here |
@dantegd after adding these 4 distance metrics the compilation time on cuML increases by almost 4x because of which the build is getting timed out. |
Does that mean 4 times the total compile time of
If the increase build time is due to template instantiations, an approach like the one here #3514 doing explicit instantiations, but it depends what is the reason behind the increase in compile time. I was wondering if you could provide some more explanation of what is causing the increase? |
I think it is libcuml++ and also the tests ml/prims. I have now tried to use pairwise_distance from "<cuml/metrics/metrics.hpp>" instead of raft wherever feasible to reuse the compiled kernels from pairwise_distance.cu in cuML. that does reduce the compilation time by a good margin but still it takes time due to increase in number of pairwise_distance kernel. |
…to enable parallel compilation. this helps reduce build time substantially with cuda 11.2 but with cuda 11.0 it is still slow due to perhaps some compiler issue with pow/powf
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #3990 +/- ##
===============================================
Coverage ? 85.46%
===============================================
Files ? 230
Lines ? 18139
Branches ? 0
===============================================
Hits ? 15502
Misses ? 2637
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
…pidsai#3990) This PR relies on RAFT PR rapidsai/raft#276 which adds these distance metrics support. Authors: - Mahesh Doijade (https://github.com/mdoijade) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Corey J. Nolet (https://github.com/cjnolet) - AJ Schmidt (https://github.com/ajschmidt8) URL: rapidsai#3990
This PR relies on RAFT PR rapidsai/raft#276 which adds these distance metrics support.