Promote trustworthiness_score to public header, add missing includes, update dependencies
#3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
conda
trxcllnt
changed the title
trustworthiness_score to public header, fix include paths, update dependenciestrustworthiness_score to public header, add missing includes, update dependencies
cjnolet
added
non-breaking
…ude-paths-dependency-versions-and-metrics-header
…arge enough to hold the accumulated sums (NVIDIA/cub#201)
|
rerun tests (we just pushed/deployed some CI fixes) |
dantegd
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Thanks for all the improvements! Approving, though the relevant CI jobs are showing the following doxygen issue (which is tricky to parse in the logs):
Generating docs for compound ML:/workspace/cpp/include/cuml/metrics/metrics.hpp:344: error: argument 'in' of command @param is not found in the argument list of ML::Metrics::trustworthiness_score(const raft::handle_t &h, const math_t *X, math_t *X_embedded, int n, int m, int d, int n_neighbors, int batchSize) (warning treated as error, aborting now)
We should be able to merge once that's fixed. Thanks!
| NULL, cub_bytes, f_idx.data(), f_idx_sorted.data(), f_sorted.data(), | ||
| f_sorted.data(), n_train, 0, 8 * sizeof(int), stream); | ||
| NULL, cub_bytes, f_sorted.data(), f_sorted.data(), f_idx.data(), | ||
| f_idx_sorted.data(), n_train, 0, 8 * sizeof(math_t), stream); |
😿 |
…ude-paths-dependency-versions-and-metrics-header
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #3968 +/- ##
===============================================
Coverage ? 85.32%
===============================================
Files ? 230
Lines ? 18095
Branches ? 0
===============================================
Hits ? 15439
Misses ? 2656
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dantegd
approved these changes
Jun 16, 2021
ajschmidt8
approved these changes
Jun 16, 2021
|
@gpucibot merge |
RAMitchell
reviewed
Jun 17, 2021
| @@ -23,6 +23,10 @@ dependencies: | |||
| - umap-learn | |||
| - scikit-learn=0.23.1 | |||
| - treelite=1.3.0 | |||
| - statsmodels | |||
There was a problem hiding this comment.
What are these new dependencies for? Just curious.
There was a problem hiding this comment.
They're required in cuML Python tests, but only listed in the rapids-test-env metapackage.
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…s, update dependencies (rapidsai#3968) * Updates dask/distributed versions to match cuDF (rapidsai/cudf#8458) * Updates to Thrust v1.12.0 to align with cuDF and cuGraph * Don't include the src and src_prims directories in `cuml::cuml++` target's public include paths * Add missing `<cstddef>` and `<cstdint>` include directives * Promote `trustworthiness_score` to public `cuml/metrics/metrics.hpp` header and update Cython * Compile Cython with `-std=c++17` * Remove `-Wstrict-prototypes` Cython warning * Fixes linker error in debug builds * Fixes rapidsai#3885 Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - AJ Schmidt (https://github.com/ajschmidt8) URL: rapidsai#3968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuml::cuml++target's public include paths<cstddef>and<cstdint>include directivestrustworthiness_scoreto publiccuml/metrics/metrics.hppheader and update Cython-std=c++17-Wstrict-prototypesCython warning