Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: fix the bug in pdf_to_cdf device function that causes hang when n_bins > TPB && n_bins % TPB != 0 #3921

Merged
merged 2 commits into from
Jun 1, 2021
Merged

RF: fix the bug in pdf_to_cdf device function that causes hang when n_bins > TPB && n_bins % TPB != 0 #3921

merged 2 commits into from
Jun 1, 2021

Conversation

venkywonka
Copy link
Contributor

@venkywonka venkywonka requested a review from a team as a code owner June 1, 2021 16:11
@venkywonka venkywonka mentioned this pull request Jun 1, 2021
Merged
@venkywonka venkywonka added the non-breaking Non-breaking change label Jun 1, 2021
@dantegd dantegd added the bug Something isn't working label Jun 1, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@95efa25). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #3921   +/-   ##
===============================================
  Coverage                ?   85.18%           
===============================================
  Files                   ?      228           
  Lines                   ?    17927           
  Branches                ?        0           
===============================================
  Hits                    ?    15272           
  Misses                  ?     2655           
  Partials                ?        0
Flag Coverage Δ
dask 47.82% <0.00%> (?)
non-dask 77.45% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95efa25...773c660. Read the comment docs.

dantegd
dantegd approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner approval

@dantegd
Copy link
Member

dantegd commented Jun 1, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6cb800a into rapidsai:branch-21.06 Jun 1, 2021
@venkywonka
Copy link
Contributor Author

thank you for the quick merge!

vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@venkywonka
RF: fix the bug in pdf_to_cdf device function that causes hang when…
64fa880 
… `n_bins > TPB && n_bins % TPB != 0` (rapidsai#3921)

* This mini-(but important)-PR fixes the bug in `pdf_to_cdf` device function that causes hang when `n_bins > TPB && n_bins % TPB != 0`
* This closes rapidsai#3919

Authors:
  - Venkat (https://github.com/venkywonka)

Approvers:
  - Philip Hyunsu Cho (https://github.com/hcho3)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cuml RF Regressor hangs indefinitely for n_bins that are not multiples of TPB
4 participants
@venkywonka @codecov-commenter @dantegd @hcho3