Fix typo in umap target_weight parameter
#3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowener
added
3 - Ready for Review
dantegd
reviewed
May 29, 2021
| @@ -871,7 +881,7 @@ class UMAP(Base, | |||
| "a", | |||
| "b", | |||
| "target_n_neighbors", | |||
| "target_weights", | |||
| "target_weight", | |||
There was a problem hiding this comment.
We might need to do an exception in test_base_children_get_param_names for the renamed parameter during 21.06, could you also create an issue to remove the parameter from 21.08 and the test exception?
dantegd
added
4 - Waiting on Author
lowener
added
4 - Waiting on Reviewer
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #3914 +/- ##
===============================================
Coverage ? 85.08%
===============================================
Files ? 228
Lines ? 17804
Branches ? 0
===============================================
Hits ? 15149
Misses ? 2655
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
dantegd
approved these changes
Jun 1, 2021
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Closes rapidsai#3748. This will fix the UMAP argument in the Python and C++ side to stay consistent. Authors: - Micka (https://github.com/lowener) Approvers: - Victor Lafargue (https://github.com/viclafargue) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#3914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3748.
This will fix the UMAP argument in the Python and C++ side to stay consistent.