-
Notifications
You must be signed in to change notification settings - Fork 335
Silence compiler warnings about host device destructor #4960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence compiler warnings about host device destructor #4960
Conversation
We are seeing spurious compiler warnings like error: calling a __host__ function("std::vector<...> ::~vector()") from a __host__ __device__ function("cugraph::edge_property_view_t<...> ::~edge_property_view_t") is not allowed This is clearly a compiler bug that has been fixed but affects 12.5 which is what runs in CI
Do you know when we will switch to 12.8 in CI? I am wondering whether we should add a hack to silence a spurious warning or if we are switching to 12.8 sometime soon, just better wait. I am locally using CUDA 12.8 and I don't see this warning. |
Probably only when moving towards the next major CTK version, so 🤷 |
@ChuckHastings can we rerun CI on this one? I do not see any reason this would affect any python tests |
I think there is a CI issue affecting every PR in cugraph. I will rerun CI once other PRs start to pass CI again. |
/merge |
We found the issue to be in some unclear compile issues within libcu++ `not_fn`, so we can revert all those hacks Revert "Silence compiler warnings about host device destructor (#4960)" Revert "[CTK 12.5]: Avoid another compiler issue with host device detection (#4971)" Authors: - Michael Schellenberger Costa (https://github.com/miscco) Approvers: - Seunghwa Kang (https://github.com/seunghwak) URL: #4985
We are seeing spurious compiler warnings like
This is clearly a compiler bug that has been fixed but affects 12.5 which is what runs in CI
Example here