Skip to content

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Mar 7, 2025

We are seeing spurious compiler warnings like

error: calling a host function("std::vector<...> ::~vector()") from a host device function("cugraph::edge_property_view_t<...> ::~edge_property_view_t") is not allowed

This is clearly a compiler bug that has been fixed but affects 12.5 which is what runs in CI

Example here

We are seeing spurious compiler warnings like

error: calling a __host__ function("std::vector<...> ::~vector()") from a __host__ __device__ function("cugraph::edge_property_view_t<...> ::~edge_property_view_t") is not allowed

This is clearly a compiler bug that has been fixed but affects 12.5 which is what runs in CI
@miscco miscco requested a review from a team as a code owner March 7, 2025 14:17
@seunghwak
Copy link
Contributor

Do you know when we will switch to 12.8 in CI? I am wondering whether we should add a hack to silence a spurious warning or if we are switching to 12.8 sometime soon, just better wait. I am locally using CUDA 12.8 and I don't see this warning.

@miscco
Copy link
Contributor Author

miscco commented Mar 10, 2025

Do you know when we will switch to 12.8 in CI? I am wondering whether we should add a hack to silence a spurious warning or if we are switching to 12.8 sometime soon, just better wait. I am locally using CUDA 12.8 and I don't see this warning.

Probably only when moving towards the next major CTK version, so 🤷

@miscco
Copy link
Contributor Author

miscco commented Mar 10, 2025

@ChuckHastings can we rerun CI on this one? I do not see any reason this would affect any python tests

@seunghwak
Copy link
Contributor

@ChuckHastings can we rerun CI on this one? I do not see any reason this would affect any python tests

I think there is a CI issue affecting every PR in cugraph. I will rerun CI once other PRs start to pass CI again.

@seunghwak seunghwak added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 11, 2025
@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 731fdd9 into rapidsai:branch-25.04 Mar 12, 2025
81 checks passed
@miscco miscco deleted the silence_compiler_issue_host_device branch March 18, 2025 12:47
miscco added a commit to miscco/cugraph that referenced this pull request Mar 19, 2025
rapids-bot bot pushed a commit that referenced this pull request Mar 19, 2025
We found the issue to be in some unclear compile issues within libcu++ `not_fn`, so we can revert all those hacks


Revert "Silence compiler warnings about host device destructor (#4960)"
Revert "[CTK 12.5]: Avoid another compiler issue with host device detection (#4971)"

Authors:
  - Michael Schellenberger Costa (https://github.com/miscco)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #4985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants