update handling of GNN dependencies #4947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4935
There, in #4935 (comment), we discussed the that GNN packages shouldn't need to be installed in docs builds any more, as no docs in this repo (including notebooks) require them.
This PR limits dependencies on the GNN packages to only the places they're needed.
libwholegraph
/pylibwholegraph
git grep -i -E 'wholegraph'
Optional runtime dependency of
cugraph
:cugraph/python/cugraph/cugraph/gnn/feature_storage/feat_storage.py
Line 23 in 2873ff9
And optional test-time dependency of
cugraph
:cugraph/python/cugraph/cugraph/tests/data_store/test_gnn_feat_storage_wholegraph.py
Lines 24 to 25 in 2873ff9
But not used in any docs.
Changes: Removed from
docs
environment.cugraph-dgl
git grep -i -E 'cugraph.*dgl'
Not used anywhere in this repo.
Changes: Removed all remaining references.
cugraph-pyg
git grep -i -E 'cugraph.*pyg'
Only used as an optional import in
cugraph-service-client
's tests (which are not run in CI for wheels).cugraph/python/cugraph-service/tests/test_remote_graph.py
Line 662 in 2873ff9
Changes: Removed from the
docs
environment, added a[test]
extra tocugraph-service-client
including this.Notes for Reviewers
Related to these issues about moving more GNN stuff out of this repo: