[DO NOT MERGE] Experiment to leverage CUDASTF #4833
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugonnet
commented
Dec 12, 2024
| @@ -15,6 +15,13 @@ | |||
| # This function finds CCCL and sets any additional necessary environment variables. | |||
| function(find_and_configure_cccl) | |||
| include(${rapids-cmake-dir}/cpm/cccl.cmake) | |||
| include(${rapids-cmake-dir}/cpm/package_override.cmake) | |||
|
|
|||
| rapids_cpm_package_override("${CMAKE_CURRENT_FUNCTION_LIST_DIR}/cccl_override.json") | |||
There was a problem hiding this comment.
This may be something we surround with some CUGRAPH_USE_STF option for example
BradReesWork
added
improvement
|
/ok to test |
|
/okay to test |
cpp/tests/utilities/check_utilities.hpp: In member function ‘bool cugraph::test::device_nearly_equal<type_t>::operator()(type_t, type_t) const’: cpp/tests/utilities/check_utilities.hpp:98:20: error: ‘max’ is not a member of ‘thrust’ 98 | thrust::max(thrust::max(lhs, rhs) * threshold_ratio, threshold_magnitude); | ^~~
instantiate using lambda functions. These lambda functions may have capture lists so that there is no default constructor, and we cannot call the default constructor of this operator.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
caugonnet
commented
Mar 27, 2025
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| #include <raft/core/handle.hpp> | |||
| #include <raft/core/span.hpp> | |||
| #include <thrust/extrema.h> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to explore how we can use CUDASTF within cuGraph