Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Series.divide and DataFrame.divide #9630

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 8, 2021

The new methods are trivial aliases for the truediv method. Resolves #9627.

@vyasr vyasr requested a review from a team as a code owner November 8, 2021 19:24
@vyasr vyasr self-assigned this Nov 8, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 8, 2021
@vyasr vyasr added 3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change labels Nov 8, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 8, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #9630 (9b6b2a7) into branch-21.12 (ab4bfaa) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 9b6b2a7 differs from pull request most recent head 50246bd. Consider uploading reports for the commit 50246bd to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9630      +/-   ##
================================================
- Coverage         10.79%   10.66%   -0.13%     
================================================
  Files               116      117       +1     
  Lines             18869    19823     +954     
================================================
+ Hits               2036     2115      +79     
- Misses            16833    17708     +875     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f16d4c...50246bd. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 34832f6 into rapidsai:branch-21.12 Nov 8, 2021
@vyasr vyasr deleted the feature/issue_9627 branch January 14, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] DataFrame divide
2 participants