Update pre-commit hook URLs. #9433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9433 +/- ##
================================================
- Coverage 10.79% 10.78% -0.01%
================================================
Files 116 116
Lines 18869 19446 +577
================================================
+ Hits 2036 2098 +62
- Misses 16833 17348 +515
Continue to review full report at Codecov.
|
vyasr
approved these changes
Oct 13, 2021
bdice
added
4 - Needs cuDF (Python) Reviewer
and removed
3 - Ready for Review
shwina
approved these changes
Oct 15, 2021
|
@gpucibot merge |
bdice
added
5 - Ready to Merge
This was referenced Oct 15, 2021
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
…9490) Some changes in #9412 and #9433 may lead to conflicts in VSCode / rapids-compose behavior for many developers. I am closing my PRs #9448 and #9450 for the same reason. See #9450 (comment) for details. This PR reverts the problematic parts of #9412 and #9433, and makes the pre-commit configuration and the conda environment pinnings consistent. Tagging @vyasr @galipremsagar @ajschmidt8 for awareness. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Vyas Ramasubramani (https://github.com/vyasr) URL: #9490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #9412, this PR updates some pre-commit hook URLs that have moved. This now uses the canonical URLs instead of a redirect.
Note: As of PR #9412, the pre-commit configuration is used for style checks on CI. The versions used by pre-commit are in a separate virtual environment from any linters/formatters in the user's local/conda environment.
I also updated the pinned versions of
flake8,pydocstyle, andisort, which are more than a year old. The updates to these hooks do not require any changes to the code for compliance, and I do not anticipate any PR conflicts. Users of pre-commit will be automatically upgraded next time pre-commit runs. I did not upgradeblackormypy:blackto the latest version introduces a relatively large number of small formatting changes and should be handled in a separate PR.mypyto the latest version introduces an issue I reported in Pin mypy in .pre-commit-config.yaml to match conda environment pinning. #9300 and should be handled in a separate PR.