New array conversion methods #9236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
feature request
thomcom
reviewed
Sep 16, 2021
vyasr
force-pushed
the
refactor/more_frame_methods
branch
from
b71316b to
ac7c43d
Compare
|
rerun tests |
github-actions
bot
removed
libcudf
vyasr
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9236 +/- ##
===============================================
Coverage ? 10.75%
===============================================
Files ? 116
Lines ? 19429
Branches ? 0
===============================================
Hits ? 2090
Misses ? 17339
Partials ? 0 Continue to review full report at Codecov.
|
isVoid
approved these changes
Sep 30, 2021
|
rerun tests |
charlesbluca
approved these changes
Oct 1, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cuxfilter
that referenced
this pull request
Feb 2, 2022
This PR fixes breaking changes made in: rapidsai/cudf#9236 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) - Ajay Thorve (https://github.com/AjayThorve) URL: #348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
to_numpyandto_cupymethods.to_numpyis the preferred method for generating numpy arrays as of pandas 1.0 when older methods liketo_matrixwere removed. This PR deprecates those old methods as well as their gpu counterparts (such asas_gpu_matrix) and instead addsto_cupyas the preferred method of getting a__cuda_array_interface__compliant array view. The new methods are also preferred to the.valuesand.values_hostaccessors, which are not yet deprecated in pandas but are likely to be deprecated at some point due to the ambiguity of their copy semantics.