Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scatter struct_scalar #8630

Merged
merged 11 commits into from
Jul 9, 2021
Merged

Support Scatter struct_scalar #8630

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a51b8ca
initial
isVoid Jun 30, 2021
a23b3ee
Refactors scattering bitmasks, more tests
isVoid Jun 30, 2021
708f8a8
Remove stale includes
isVoid Jul 1, 2021
1f6215b
More include fixes
isVoid Jul 1, 2021
06cd573
Apply suggestions from code review
isVoid Jul 6, 2021
03bdd1c
make more declarative
isVoid Jul 6, 2021
5464563
doc
isVoid Jul 6, 2021
b2ee8ae
doc
isVoid Jul 6, 2021
c11606b
review change
isVoid Jul 7, 2021
0eb2eb9
Merge branch 'branch-21.08' of https://github.com/rapidsai/cudf into …
isVoid Jul 8, 2021
199eccf
style
isVoid Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc
  • Loading branch information
@isVoid
isVoid committed Jul 6, 2021
commit b2ee8ae6851411c53165a744c1d001c513eab2d4
4 changes: 2 additions & 2 deletions cpp/src/copying/scatter.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ struct column_scalar_scatterer_impl<struct_view, MapIterator> {
});
std::vector<std::unique_ptr<column>> fields(fields_iter_begin, fields_iter_begin + n_fields);

// Compute nullmask
// Compute null mask
rmm::device_buffer null_mask =
target.nullable() ? copy_bitmask(target, stream, mr)
: create_null_mask(target.size(), mask_state::UNALLOCATED, stream, mr);
Expand All @@ -269,7 +269,7 @@ struct column_scalar_scatterer_impl<struct_view, MapIterator> {
size_type null_count = null_mask_stub.null_count();
auto contents = null_mask_stub.release();

// Nullmask pushdown inside factory method
// Null mask pushdown inside factory method
return make_structs_column(
target.size(), std::move(fields), null_count, std::move(*contents.null_mask));
}
Expand Down