Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strings::repeat_strings API that can repeat each string a different number of times #8561

Merged
merged 37 commits into from
Jul 20, 2021
Merged

Add strings::repeat_strings API that can repeat each string a different number of times #8561

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f0b5ff7
Add doxygen
ttnghia Jun 17, 2021
a61c1e7
Finish implementation
ttnghia Jun 18, 2021
2639f9a
Finish unit tests
ttnghia Jun 18, 2021
dbbfbf9
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jun 18, 2021
0dec873
Fix merge conflicts
ttnghia Jun 18, 2021
143f853
Rename parameter back to `input`
ttnghia Jun 21, 2021
b39bb06
Fix typo
ttnghia Jun 21, 2021
ae40591
Rewrite using type_dispatcher for different integer types
ttnghia Jun 21, 2021
8612f61
Fix comment typo
ttnghia Jun 21, 2021
3dfec42
Remove input check for int32_t data type
ttnghia Jun 21, 2021
d230498
Remove bool type from the expecting types for `repeat_times` data type
ttnghia Jun 21, 2021
f534372
Implement overflow check for the new API, as it can't be done outside…
ttnghia Jun 21, 2021
554d20d
Update doxygen
ttnghia Jun 21, 2021
d00ba01
Add typed tests for various types of `repeat_times` column
ttnghia Jun 21, 2021
5b5c2a4
Fix doxygen
ttnghia Jun 21, 2021
d488eca
Simplify overflow checking
ttnghia Jun 21, 2021
8498fc6
Just re-order code
ttnghia Jun 21, 2021
855a774
Add a parameter to allow turning on/off overflow checking
ttnghia Jun 24, 2021
e5f5db8
Implement overflow checking
ttnghia Jun 25, 2021
50f05fd
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jun 25, 2021
0bcf8d8
Redesign the API and update doxygen
ttnghia Jun 25, 2021
c7b7c3b
Add an optional column of pre-computed output strings offsets
ttnghia Jul 7, 2021
f6d7ee3
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jul 8, 2021
d22c4e5
Finish implementation
ttnghia Jul 8, 2021
6124e83
Fix JNI
ttnghia Jul 8, 2021
90517aa
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jul 8, 2021
7795f54
Cleanup
ttnghia Jul 8, 2021
9158e4f
Remove duplicate code
ttnghia Jul 9, 2021
5e37782
Add test for computing string output sizes that causes overflow
ttnghia Jul 9, 2021
4dfca75
Fix test build error
ttnghia Jul 9, 2021
95cb6c0
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jul 9, 2021
91c414e
Simple fix comment typo
ttnghia Jul 9, 2021
00ad095
Address review comments, fixing doxygen and some code improvements
ttnghia Jul 19, 2021
b7956e4
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jul 19, 2021
bebb9e6
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jul 19, 2021
5c554c1
Cleanup header
ttnghia Jul 20, 2021
b294f52
Merge branch 'branch-21.08' into repeat_strings
ttnghia Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'branch-21.08' into repeat_strings
  • Loading branch information
@ttnghia
ttnghia committed Jun 18, 2021
commit dbbfbf9b92abf0b7f22bfc6a4212372b931d4a98

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.