Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_integer API that can check for the validity of a string-to-integer conversion #7642

Merged
merged 27 commits into from
Mar 24, 2021
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
9a2229b
Finish is_integer tests with bound check
ttnghia Mar 18, 2021
5854ebb
Implement is_integer with checking for both underflow and overflow
ttnghia Mar 18, 2021
34944f7
Re-implement to_integer which will re-generate bitmask using the vali…
ttnghia Mar 18, 2021
a53ecbe
Rewrite tests for is_integer and to_integer with bound check
ttnghia Mar 18, 2021
00ccbe4
Add test for is_integer in case the input strings column has null
ttnghia Mar 18, 2021
5e9293c
Update doc
ttnghia Mar 18, 2021
26c4772
Reverse code for doing null check while calling to_integer
ttnghia Mar 18, 2021
69ca9e5
Reverse tests for doing null check while calling to_integer
ttnghia Mar 18, 2021
239df00
Some small cleanups
ttnghia Mar 18, 2021
57d2785
Fix typos
ttnghia Mar 19, 2021
3d0c0d9
Rename name aliases and split tests
ttnghia Mar 19, 2021
702f69d
Reverse back to the ugly, long type names
ttnghia Mar 19, 2021
c32f506
Use the default printing option for testing
ttnghia Mar 19, 2021
a7bc901
Fix constness of mutable_column_view
ttnghia Mar 19, 2021
226e125
Add back the original `is_integer` API that does not check for under/…
ttnghia Mar 19, 2021
e8b71b8
Fix constness of mutable_view reference, add back the old is_integer …
ttnghia Mar 19, 2021
d6214e8
Add comment to code
ttnghia Mar 19, 2021
41b5dab
Just rename variable
ttnghia Mar 19, 2021
551f68d
Rewrite tests for is_integer and to_integer
ttnghia Mar 19, 2021
5502270
Remove unused header
ttnghia Mar 19, 2021
ef19286
Fix doc
ttnghia Mar 19, 2021
ae80834
Remove printing option from CUDF_TEST_EXPECT_COLUMNS_EQUAL
ttnghia Mar 22, 2021
4bd7954
Prevent ClangFormat from automatically reorganizing the namespaces' c…
ttnghia Mar 22, 2021
724d8e5
Move the detail APIs out of the anonymous namespace
ttnghia Mar 22, 2021
2fcd5a7
Update cpp/tests/strings/integers_tests.cu
ttnghia Mar 22, 2021
8d5895e
Merge branch 'branch-0.19' into convert_integer_bound_check
ttnghia Mar 23, 2021
f2daef9
Change from using thrust::counting_iterator to pair iterator
ttnghia Mar 23, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prevent ClangFormat from automatically reorganizing the namespaces' c…
…losing braces
  • Loading branch information
ttnghia committed Mar 22, 2021
commit 4bd795474e726ae4d605d6b58fef33e1844c06c1
2 changes: 1 addition & 1 deletion cpp/src/strings/convert/convert_integers.cu
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ std::unique_ptr<column> is_integer(
return type_dispatcher(int_type, dispatch_is_integer_fn{}, strings, stream, mr);
}

} // namespace
} // namespace detail
} // namespace anonymous

// external APIs
std::unique_ptr<column> is_integer(strings_column_view const& strings,
Expand Down