Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add support for array-like inputs in cudf.get_dummies #7181

Merged
merged 4 commits into from
Jan 21, 2021

Conversation

galipremsagar
Copy link
Contributor

FIxes: #7031

This PR introduces array-like inputs support in cudf.get_dummies. I think in near future we will have to deprecate and adapt new name for get_dummies: pandas-dev/pandas#35724

@galipremsagar galipremsagar added feature request New feature or request 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Jan 21, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner January 21, 2021 03:22
@galipremsagar galipremsagar self-assigned this Jan 21, 2021
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/reshape.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/reshape.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/reshape.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/reshape.py Show resolved Hide resolved
python/cudf/cudf/core/reshape.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #7181 (de61f25) into branch-0.18 (8860baf) will increase coverage by 0.07%.
The diff coverage is 89.01%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7181      +/-   ##
===============================================
+ Coverage        82.09%   82.16%   +0.07%     
===============================================
  Files               97       97              
  Lines            16474    16559      +85     
===============================================
+ Hits             13524    13606      +82     
- Misses            2950     2953       +3     
Impacted Files Coverage Δ
python/cudf/cudf/_lib/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 91.66% <ø> (-0.09%) ⬇️
python/cudf/cudf/utils/ioutils.py 78.71% <ø> (ø)
python/cudf/cudf/core/dataframe.py 90.71% <50.00%> (+<0.01%) ⬆️
python/cudf/cudf/io/orc.py 86.89% <63.63%> (-1.51%) ⬇️
python/cudf/cudf/core/dtypes.py 89.50% <66.66%> (-0.88%) ⬇️
python/cudf/cudf/core/series.py 91.10% <80.00%> (-0.06%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.08% <83.33%> (-0.33%) ⬇️
python/cudf/cudf/io/csv.py 91.66% <86.66%> (-1.67%) ⬇️
python/cudf/cudf/core/frame.py 89.90% <88.88%> (-0.08%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4111cb7...de61f25. Read the comment docs.

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jan 21, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4c6a57c into rapidsai:branch-0.18 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Run get_dummies on cudf Series
2 participants