Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Adding support for explode to cuDF #7140

Merged
merged 10 commits into from
Jan 25, 2021
Merged

[REVIEW] Adding support for explode to cuDF #7140

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1a8c59d
First pass at explode
hyperbolic2346 Jan 13, 2021
69acc15
Updating based on review comments, adding more tests, and adding null…
hyperbolic2346 Jan 14, 2021
368e396
removing debug code and adding device_uvector back
hyperbolic2346 Jan 14, 2021
99ff76c
Adding some struct tests
hyperbolic2346 Jan 15, 2021
d62e031
Adding documentation on nulls
hyperbolic2346 Jan 15, 2021
7e11612
fixing unsigned int -> size_type
hyperbolic2346 Jan 16, 2021
7fc7c04
removing unused variable in tests
hyperbolic2346 Jan 19, 2021
0ae9cd6
Review comments, fixing sliced columns, added sliced column test
hyperbolic2346 Jan 21, 2021
898c98d
Adding more detail to header comments and addressing review comments
hyperbolic2346 Jan 22, 2021
fed595a
Adding comment to offset_minus_one +1 line that looks like a bug
hyperbolic2346 Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing unsigned int -> size_type
  • Loading branch information
@hyperbolic2346
hyperbolic2346 committed Jan 16, 2021
commit 7e1161208401b36b1a02a1a5e0fc730e4591040c
2 changes: 1 addition & 1 deletion cpp/src/reshape/explode.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ std::unique_ptr<table> explode_functor::operator()<list_view>(
explode column. This unrolls the top level of lists. Then we need to insert the explode column
back into the table and return it. */
lists_column_view lc{input_table.column(explode_column_idx)};
rmm::device_uvector<unsigned int> gather_map_indices(lc.child().size(), stream, mr);
rmm::device_uvector<size_type> gather_map_indices(lc.child().size(), stream, mr);
auto offsets = lc.offsets();

auto offsets_minus_one = thrust::make_transform_iterator(offsets.begin<size_type>(),
Expand Down