Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method field to fillna for fixed width columns #6998

Merged
merged 7 commits into from
Dec 17, 2020

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Dec 11, 2020

Closes #1361

  • Provides "ffill" and "bfill" fillna methods for Numerical, Datetime, Timedelta and Categorical type column.
  • Supports method parameter for Series.fillna and DataFrame.fillna

@isVoid isVoid requested a review from a team as a code owner December 11, 2020 22:03
@isVoid isVoid requested review from trxcllnt and shwina December 11, 2020 22:03
@isVoid isVoid self-assigned this Dec 11, 2020
@isVoid isVoid added feature request New feature or request Python Affects Python cuDF API. non-breaking Non-breaking change 3 - Ready for Review Ready for review by team labels Dec 11, 2020
@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #6998 (fd9d49f) into branch-0.18 (ab8c931) will increase coverage by 0.04%.
The diff coverage is 81.03%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #6998      +/-   ##
===============================================
+ Coverage        82.01%   82.06%   +0.04%     
===============================================
  Files               96       96              
  Lines            16338    16399      +61     
===============================================
+ Hits             13400    13458      +58     
- Misses            2938     2941       +3     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/categorical.py 93.35% <60.00%> (+0.01%) ⬆️
python/cudf/cudf/core/column/string.py 86.48% <75.00%> (-0.10%) ⬇️
python/cudf/cudf/core/frame.py 90.26% <75.00%> (-0.09%) ⬇️
python/cudf/cudf/core/column/timedelta.py 89.16% <87.50%> (-0.38%) ⬇️
python/cudf/cudf/core/column/column.py 88.14% <100.00%> (+0.21%) ⬆️
python/cudf/cudf/core/column/datetime.py 89.42% <100.00%> (+0.53%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.41% <100.00%> (-0.13%) ⬇️
python/cudf/cudf/core/series.py 91.10% <100.00%> (ø)
python/cudf/cudf/io/dlpack.py 95.23% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8c931...fd9d49f. Read the comment docs.

@isVoid
Copy link
Contributor Author

isVoid commented Dec 12, 2020

rerun tests

@isVoid
Copy link
Contributor Author

isVoid commented Dec 16, 2020

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge and removed 3 - Ready for Review Ready for review by team labels Dec 17, 2020
@rapids-bot rapids-bot bot merged commit 4385f54 into rapidsai:branch-0.18 Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Add forward and backward fill options to DataFrame.fillna
3 participants