Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Avoid inserting null elements into join hash table when nulls are treated as unequal #6943

Merged
merged 19 commits into from
Dec 11, 2020
Merged

[REVIEW] Avoid inserting null elements into join hash table when nulls are treated as unequal #6943

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1e1086e
Initial pass at fixing nulls not equal performance with joins
hyperbolic2346 Dec 8, 2020
2020b4c
Merge remote-tracking branch 'upstream/branch-0.18' into mwilson/join…
hyperbolic2346 Dec 8, 2020
95f791f
adding changelog
hyperbolic2346 Dec 8, 2020
7db4f1b
Apply suggestions from code review
hyperbolic2346 Dec 8, 2020
539f461
removing stale comments
hyperbolic2346 Dec 9, 2020
cb88696
Merge branch 'mwilson/join_nulls' of github.com:hyperbolic2346/cudf i…
hyperbolic2346 Dec 9, 2020
8af46b2
attempting to clarify parameter comments
hyperbolic2346 Dec 9, 2020
e1ee434
moving device view creation up into build_join_hash_table and only pa…
hyperbolic2346 Dec 10, 2020
1e6461d
Merge remote-tracking branch 'upstream/branch-0.18' into mwilson/join…
hyperbolic2346 Dec 10, 2020
3d77c73
updating based on review
hyperbolic2346 Dec 10, 2020
e2f2810
Apply suggestions from code review
hyperbolic2346 Dec 10, 2020
9ab1e19
Adding srand per review comments
hyperbolic2346 Dec 10, 2020
6b0e5d4
linting
hyperbolic2346 Dec 10, 2020
2e233da
review comment changes
hyperbolic2346 Dec 10, 2020
5b66b19
Merge remote-tracking branch 'upstream/branch-0.18' into mwilson/join…
hyperbolic2346 Dec 10, 2020
e57855a
Apply suggestions from code review
hyperbolic2346 Dec 11, 2020
d300ad6
Merge remote-tracking branch 'upstream/branch-0.18' into mwilson/join…
hyperbolic2346 Dec 11, 2020
a458a84
cleanup and fixes for UniformRandomGenerator
hyperbolic2346 Dec 11, 2020
39403b2
linting
hyperbolic2346 Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/branch-0.18' into mwilson/join… 
…_nulls
  • Loading branch information
@hyperbolic2346
hyperbolic2346 committed Dec 8, 2020
commit 2020b4c0f418ff7eaaad86f87351d45997bed2ff

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.